search

StanfordAHA / CGRAFlow

Integration test for entire CGRA flow
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Srtest #24

Closed steveri closed 6 years ago

steveri commented 6 years ago

Added bitstream checker to the flow, see your email for details. Passes all existing tests.

steveri commented 6 years ago

Ha ha pull request build FAILED because of randomness in PNR which uncovered a bug. I fixed the bug and restarted the build, hopefully it passes this time...

steveri commented 6 years ago

Lenny, that's actually good feedback; I will add a comment to the makefile before merging.  Something like "hackdiff compares PNR bitstream intent (encoded as annotations to the bitstream) versus a separately-decoded version of the bitstream, to make sure they match" Steve

  From: Leonard (Lenny) Truong <notifications@github.com>

To: StanfordAHA/CGRAFlow CGRAFlow@noreply.github.com Cc: steveri steveri@steveri.com; Assign assign@noreply.github.com Sent: Wednesday, August 2, 2017 10:29 AM Subject: Re: [StanfordAHA/CGRAFlow] Srtest (#24)

@leonardt approved this pull request.Makefile changes look good to me, although I have no idea what CGRAGenerator/bitstream/decoder/hackdiff.csh does, so I'll have to trust that it works properly— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.