StanfordAHA / CGRAFlow

Integration test for entire CGRA flow
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Clean up travis script #4

Open steveri opened 7 years ago

steveri commented 7 years ago

Pat recommended (and I agree) that we clean up the travis script by wrapping each flow stage into a called or sourced shell script e.g. instead of

  - git clone https://github.com/jeffsetter/Halide_CoreIR.git
  - export CXX=${CXX_}
  - export CC=${CC_}
  - export LLVM_CONFIG=${TRAVIS_BUILD_DIR}/llvm/bin/llvm-config
  - export CLANG=${TRAVIS_BUILD_DIR}/llvm/bin/clang
  - export CORECONFIG="g++-4.9"
  - export COREIR_DIR=${TRAVIS_BUILD_DIR}/coreir

it might read something like

  - echo "INSTALL COREIR"
  - git clone https://github.com/jeffsetter/Halide_CoreIR.git
  - echo "Setup env vars (CXX, CC, LLVM_CONFIG...)"
  - source Halide_CoreIR/.travis_before_install.sh

Also, there seems to be some leftover script bits that are not directly related to the current CGRA flow, e.g. see below. Could someone (James?) please verify that these are no longer required and if so maybe remove them. Thanks!

> before_install:
>   - echo "INSTALL RIGEL"
>   - git clone https://github.com/jameshegarty/rigel.git
>   - export PKG_CONFIG_PATH=${TRAVIS_BUILD_DIR}/rigel/platform/verilator
>   - pkg-config --cflags verilator
>   - pkg-config --variable=includedir verilator
> 
> script:
>    # coreir
>   - cd coreir/tests
>   - ./run
>   - pytest  # Test python bindings
>   - cd ../..
>   
>     # rigel
>   - cd rigel/examples
>   - make out/pointwise_wide_handshake.verilator.bmp
>   - cd ../../
jameshegarty commented 7 years ago

Sounds like a good plan, I will work on this.

jeffsetter commented 7 years ago

I've worked on cleaning up the halide portion of this. Let me know if you have suggestions on a better way than I've done my changes.

steveri commented 7 years ago

Jeff, this looks great!  And the flow seems to run faster, too.  Thanks for doing it. Steve

  From: Jeff Setter <notifications@github.com>

To: StanfordAHA/CGRAFlow CGRAFlow@noreply.github.com Cc: steveri steveri@steveri.com; Assign assign@noreply.github.com Sent: Monday, April 10, 2017 7:52 PM Subject: Re: [StanfordAHA/CGRAFlow] Clean up travis script (#4)

I've worked on cleaning up the halide portion of this. Let me know if you have suggestions on a better way than I've done my changes.

jameshegarty commented 7 years ago

I remove that stuff, but the build is breaking for other reasons. I think we should have a discussion on Tues.