search

StanfordAHA / CGRAFlow

Integration test for entire CGRA flow
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

CoreIR now has a real library and include interface. Will break Jeff's code. #7

Closed rdaly525 closed 7 years ago

rdaly525 commented 7 years ago

Jeff, please create a branch for your stuff and then verify using the coreir/libreorg branch of CGRAFlow

items that will likely need to be fixed:

Add to Makefile: Add -lcoreir -lcoreir-stdlib -lcoreir-passes (Make sure to add at END of command) Add -L<Path to coreir/bin> Add -I<Path to coreir/incldue>

change getStdlib -> CoreIRLoadLibrary_stdlib Look at one of my tests (coreir/tests/unit/*.cpp) to see how to redo your includes for cpp/hpp files

jeffsetter commented 7 years ago

After downloading a clean copy of coreir and moving to the libreorg branch, I'm having a problem after "make install" with "make test." Below is the error:

build/ctest: error while loading shared libraries: libcoreir-c.so: cannot open shared object file: No such file or directory

rdaly525 commented 7 years ago

@jeffsetter, Sorry I also forgot to mention that you need to point your LD_LIBRARY_PATH to coreir/bin (or if you are on mac, point DYLD_LIBRARY_PATH)

I added this information in the README

jeffsetter commented 7 years ago

Could we instead use -rpath? Something like this, so I don't have to add to my LD_LIBRARY_PATH?

LIBS = -Wl,-rpath=$(BIN) -lcoreir-stdlib -lcoreir-passes -lcoreir

rdaly525 commented 7 years ago

@jeffsetter I do not know how to get this to work for both OSX and Linux. If you have any ideas on how to get it to work, can you stop by?

rdaly525 commented 7 years ago

@jeffsetter, just pushed the update to use rpath instead

rdaly525 commented 7 years ago

@steveri, @nikhilbhagdikar I am unsure of what the bug is here. Could you take a look at this log? https://travis-ci.org/StanfordAHA/CGRAFlow/builds/226664767

The changes we did ideally should not have affected anything with the cgra/testbench generator.

steveri commented 7 years ago

OMG I'm so sorry I can't believe I didn't check my mail since Thu evening! Anyway, I'm pretty sure this is the test.py problem that I just sent mail to Caleb about (I think you (Ross) got cc'ed, yes?) Steve

  From: rdaly525 <notifications@github.com>

To: StanfordAHA/CGRAFlow CGRAFlow@noreply.github.com Cc: steveri steveri@steveri.com; Mention mention@noreply.github.com Sent: Thursday, April 27, 2017 7:13 PM Subject: Re: [StanfordAHA/CGRAFlow] CoreIR now has a real library and include interface. Will break Jeff's code. (#7)

@steveri, @nikhilbhagdikar I am unsure of what the bug is here. Could you take a look at this log? https://travis-ci.org/StanfordAHA/CGRAFlow/jobs/226615471The changes we did ideally should not have affected anything with the cgra/testbench generator.— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jeffsetter commented 7 years ago

I just reran Build #227 on travis (as referenced above) and it appears to work. Is this resolved and can be merged into master?

rdaly525 commented 7 years ago

Closing this. Fixed by #8