search

StanfordAHA / CGRAFlow

Integration test for entire CGRA flow
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Switch to cgra_pnr #72

Closed Kuree closed 6 years ago

Kuree commented 6 years ago

Some minor changes to makefile and scripts/repo_manager.py to install cgra_pnr in the CGRAFlow. Currently it passed all the tests.

Not sure if I should remove old SMT PnR stuff...

Please let me know if you have any questions.

steveri commented 6 years ago

Keyi, this is excellent work! Especially considering that you are on vacation :)

Not sure if I should remove old SMT PnR stuff... Looks like you did remove it, yes? That's fine; the purpose of CGRAFlow is to prove that we can get from Halide to correct image-out, not to test everyone's routers...

After this / soon / eventually we need to figure out how to add cascade and halide...

Meanwhile I approve this merge.

Kuree commented 6 years ago

@steveri I think I just disabled SMT related testing, rather than deleting them.

@leonardt Sorry I didn't check that. Most of this PR was done while I'm on an airplane. I will fix related issues.

steveri commented 6 years ago

I want to approve the changes but... even though I refresh, the pull request page keeps saying checks haven't completed yet...must be a bug b/c when I look at the builds they all say "passing"...guess I will wait and see if it resolves itself :(

steveri commented 6 years ago

Okay even though it still says "checks haven't completed" I can see that they have passed so I'm going to go ahead approve this merge (again).

steveri commented 6 years ago

What is the status of this pull, why was it never completed...?

leonardt commented 6 years ago

I think we were waiting on the checks to complete, which it looks like they did.