search

StanfordAHA / Halide-to-Hardware

Other
77 stars 12 forks source link

ROM compute uses uint8_t? #108

Closed dillonhuff closed 4 years ago

dillonhuff commented 4 years ago

@jeffsetter thanks for adding that ROM example!

However I notice that the CPU and coreir implementations differ starting at output 256 when using the identity stream, and that the rom seems to be 8 bits wide?

jeffsetter commented 4 years ago

Interesting, Halide is identifying that the input is 8bits and then that value is used in the ROM. Since the range of values can only be from 0 to 255, it creates a ROM of only length 256. I'll change the clamp between 0 to 255 to fix the ROM size to 256 values.

dillonhuff commented 4 years ago

@jeffsetter thanks man!