search

StanfordAHA / Halide-to-Hardware

Other
77 stars 12 forks source link

Hls codegen with hardware buffers merge #55

Closed dillonhuff closed 4 years ago

dillonhuff commented 4 years ago

This pull request brings together the Jeff's unified buffer branch (hwbuffer_jeff), with the latest HLS code generator (which was recently merged with master).

jeffsetter commented 4 years ago

I know this has little to do with your changes, but could you help me remove some of the printouts during the execution? It's a bit hard to read the logs as is.

dillonhuff commented 4 years ago

@jeffsetter sure. Is there any particular file where you want to remove things? ExtractHWBuffers seems to be a particularly bad offender for excessive logging IMO.

jeffsetter commented 4 years ago

Yea, the major offenders will be my files (ExtractHWBuffers and InsertHWBuffers). You could remove every printout to std::cout in there.

dillonhuff commented 4 years ago

@jeffsetter just deleted a bunch of printouts. If that is the only issue could you approve this PR so that we can merge? The other printouts can be dealt with in another PR, and I think we should get in the habit of making many smaller pull requests anyway.