search

StanfordAHA / Halide-to-Hardware

Other
77 stars 12 forks source link

Refactoring of HLS code generator #63

Closed dillonhuff closed 4 years ago

dillonhuff commented 4 years ago

@jeffsetter this PR includes some refactoring to clean up the HLS code generator. It only touches the new code generator files. LMK if you see any issues with it so I can merge it.

dillonhuff commented 4 years ago

@jeffsetter also I changed the build script to use the master branch of GarnetFlow as the docker build environment, it was previously set to use a branch of GarnetFlow that has been merged to master.

jeffsetter commented 4 years ago

I don't expect these changes to affect garnetflow, but in the future it's also best to kick off a run of garnetflow with the new branch.

dillonhuff commented 4 years ago

@jeffsetter that makes sense, how do trigger garnetflow with a new branch?

jeffsetter commented 4 years ago

Right now I think it is manual, but if you're willing to do some scripting, an extension to https://github.com/StanfordAHA/GarnetFlow/blob/master/scripts/python_repo.py for Halide-to-Hardware, we could have something done automatically. Keyi and Teguh might have ideas about this.

dillonhuff commented 4 years ago

Ahh I see. We should definitely talk with those two about it.