search

StanfordAHA / Halide-to-Hardware

Other
77 stars 12 forks source link

Update to use with lakelib and new mapper #74

Closed norabarlow closed 4 years ago

norabarlow commented 4 years ago

The updated mapper works with the old code generator that produces line buffers (not unified buffers), as well as with unified buffers.

dillonhuff commented 4 years ago

@norabarlow thats great!

Have you tried running the hardware unit tests on your machine by doing:

./test/scripts/hw_unit_tests.sh

The travis build says that they are failing.

norabarlow commented 4 years ago

@dillonhuff it's complaining about ERROR: Missing namespace: lakelib, which I'm not sure how to fix. I've tried linking lakelib in the Makefile, which I pushed, but it doesn't work.

joyliu37 commented 4 years ago

Dillon's merged_hw_unit test is not using unified buffer, but just linebuffer. However, lakelib.linebuffer is just a copy paste from commonlib.linebuffer which should not result issue. Is the complaint about missing namespace: lakelib point to any line of any file?

norabarlow commented 4 years ago

@joyliu37 the errors point to somewhere inside the compiled library files, so unfortunately I can't get line numbers. I tried modifying the tests to load lakelib but it didn't work.

norabarlow commented 4 years ago

Hmm...not sure how to fix this GarnetFlow error.

leonardt commented 4 years ago

I just found about the error, looks like a regression from a recent magma change. Pushed a hot fix and re-running the builds now

leonardt commented 4 years ago

New build is running here: https://buildkite.com/stanford-aha/garnetflow/builds/1325#e0d053eb-f3ee-401b-85bc-6f91ebf62c5b but it seems like you may need to push a commit here to trigger the GitHub integration to update with a new build status

leonardt commented 4 years ago

Nevermind, looks like it's now updated the build result, passing: https://buildkite.com/stanford-aha/garnetflow/builds/1325#e0d053eb-f3ee-401b-85bc-6f91ebf62c5b