search

StanfordAHA / garnet

Next generation CGRA generator
BSD 3-Clause "New" or "Revised" License
106 stars 11 forks source link

Fix onyx gold bug #1059

Closed steveri closed 6 months ago

steveri commented 6 months ago

Oops, looks like the onyx gold check in the mflowgen buildkite pipeline has been silently failing for some time now. See e.g. this build, where the "Gold RTL" step says PASSED although, when you look at the log, it failed utterly because of a sed script error.

https://buildkite.com/tapeout-aha/mflowgen/builds/8124

Comparing 92061 lines of design.v
versus    91793 lines of onyx-4x2.v

/aha/garnet/bin/rtl-goldcompare.sh design.v onyx-4x2.v
sed: -e expression #1, char 46: unterminated `s' command
sed: -e expression #1, char 46: unterminated `s' command
Test PASSED

I fixed the sed script and also changed the test so that future failures will not say "PASSED".

https://buildkite.com/tapeout-aha/mflowgen/builds/8137

Note that the test still fails, but not silently, and not because of the sed script. This new failure will be addressed in a later change.