search

StanfordAHA / lassen

The PE for the second generation CGRA (garnet).
16 stars 4 forks source link

New peak #155

Closed rdaly525 closed 4 years ago

rdaly525 commented 4 years ago

This PR will be merged with the peak:family-master branch.

Major Changes: -Removed all family closures -Moved ALU to its own file -Created a common file for constants and common types -renamed Enums (like ALU, Mode, Cond, etc...) to have a '_t' suffix. -removed unnecessary imports

Currently, I still need to make the RTL tests work (along with Garnet), but in the meantime could @phanrahan, @cdonovick review the changes?

phanrahan commented 4 years ago

Seems good to me.

Might be nice to break the alu operations into smaller chunks, like FP and Int. But that is for another day.

Again, this is orthogonal. How do you think we are doing on tests?

rdaly525 commented 4 years ago

Yeah, there are a lot of other fixes that would be good to make in lassen including splitting up the ALU, and simplifying the Mode + initial value for registers.

phanrahan commented 4 years ago

Once you check this in I may write some more tests.