StanfordBDHG / .github

Collection of default community health files, GitHub Action workflows, templates
https://biodesigndigitalhealth.stanford.edu
3 stars 2 forks source link

Fix xcodebuild-or-fastlane when not supplying checkout_token #30

Closed Supereg closed 1 year ago

Supereg commented 1 year ago

Fix xcodebuild-or-fastlane when not supplying checkout_token

:recycle: Current situation & Problem

Recent PR #29 added the functionality to supply a PAT for checkout. This functionality was tested wrongfully (oversight where one confused the successful xcodebuild-or-fastlane of StanfordSpezi/.github with this repo).

:bulb: Proposed solution

This PR addresses the issue when not supplying a checkout_token by specifying the default gitHub.token. The checkout action failed to do so when supplying an empty token.

:gear: Release Notes

:heavy_plus_sign: Additional Information

Related PRs

Originally implemented in #29.

Testing

Functionality was verified by this CI run. The CodeQL step runs the action without supplying a checkout_token. This time it was taken care of the CodeQL action runs the same xcodebuild-or-fastlane workflow from this repository (see https://github.com/StanfordBDHG/NAMS/pull/19/commits/f98bcff78f9af18a29fde5ded9db3bf9e6e88fc5).

Reviewer Nudging

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: