Closed philippzagar closed 11 months ago
Thank you for the fix @philippzagar and thank you for the review @Supereg! Is there a way that we can catch these things earlier so we don't release broken workflows? Can you verity that the current setup is working in a separate repo @philippzagar, I suspect this is https://github.com/StanfordBDHG/ResearchKit/pull/9?
@PSchmiedmayer I thought I actually verified the workflow (from within the feature branch) in https://github.com/StanfordBDHG/ResearchKit, but apparently, I messed something up, that's completely my fault. Will definitely be more careful here in the future to not merge a broken functionality. And yes, the current setup is working in https://github.com/StanfordBDHG/ResearchKit/pull/9 and is used there to create an XCFramework and a release.
No worries, thank you for fixing this so fast!
I think we should think how we can automate some these tests in this repo to ensure that we don't run into this in the future, I created and updated an issue for this: https://github.com/StanfordBDHG/.github/issues/19
Fix nested reusable workflow
:recycle: Current situation & Problem
The original PR https://github.com/StanfordBDHG/.github/pull/40 contained an issue that reusable workflows must specify the full path of the nested reusable workflow in order to work properly. Furthermore, one must pay attention to where the JSON decoding of the
runs-on
arguments is done.:gear: Release Notes
:books: Documentation
--
:white_check_mark: Testing
--
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: