search

StanfordBDHG / ENGAGE-HF-Firebase

Firebase cloud hosting infrastructure for the ENGAGE-HF project.
MIT License
0 stars 1 forks source link

PDF export #14

Closed pauljohanneskraft closed 1 week ago

pauljohanneskraft commented 2 weeks ago

PDF Export

:recycle: Current situation & Problem

This PR adds a new Firebase Function for the creation of health summary PDF documents. The function currently always returns the same PDF, since it is using statically specified data. It will later on be modified to fetch the data from Firestore directly.

:gear: Release Notes

Add health summary PDF generation functionality

:books: Documentation

?

:white_check_mark: Testing

?

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

pauljohanneskraft commented 2 weeks ago

I am wondering if we can create a small test that can verify the output of the function based on a pre-defined input (e.g. the one you have in the cloud function definition) to validate that we don't have any major regressions in the output. Something like https://github.com/btravers/pdf-snapshot could get us a long way there and we could embed the example output that we expect right here in the repo.

I agree! Let's create a new issue for it.