StanfordBDHG / NAMS

Platform for EEG data collection from Bluetooth-enabled devices.
MIT License
5 stars 0 forks source link

Fix release builds #36

Closed Supereg closed 10 months ago

Supereg commented 10 months ago

Fix release builds

:recycle: Current situation & Problem

With the latest changes of adding a new ScheduleView and the M-CHAT R/F questionnaires (see #35), we broke the release build action.

:bulb: Proposed solution

This PR fixes the compilation issues and adds a PR Action step to verify release build before merging a PR.

:gear: Release Notes

Related PRs

--

Testing

GitHub Action was added to build the release scheme for every PR.

Reviewer Nudging

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 10 months ago

Codecov Report

Merging #36 (3965f86) into main (105f8bd) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/36/graphs/tree.svg?width=650&height=150&src=pr&token=19Q7N7RodK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG)](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG) ```diff @@ Coverage Diff @@ ## main #36 +/- ## ======================================= Coverage 84.96% 84.96% ======================================= Files 63 63 Lines 2306 2306 ======================================= Hits 1959 1959 Misses 347 347 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/36?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/36?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG). Last update [105f8bd...3965f86](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/36?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG).