Supereg commented 9 months ago

Upgrade to DSL-based SpeziBluetooth

:recycle: Current situation & Problem

This PR upgrades to the latest Spezi 1.0 releases. Further, this upgrades to the upcoming SpeziBluetooth release that introduces a new and simplified DSL API for declaring Bluetooth devices.

:gear: Release Notes

Upgrade to latest Spezi 1.0 releases
Upgrade to upcoming SpeziBluetooth releases.
Refactor the device model supporting three different devices types: Muse, Biopot, Mock.
Supporting auto connect and background auto connect with SpeziBluetooth backed devices (in our case the Biopot)
Added initial support for visionOS 🎉 (Note: visionOS builds currently don't include support for Questionnaires).
Added new "Detailed Headband Fit" view for Muse devices.
Improved discovery of Muse devices.

:books: Documentation

--

:white_check_mark: Testing

Tests were adjusted and updated.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

Supereg commented 8 months ago

@PSchmiedmayer seems like disabling the Password Auto Fill doesn't work (here/right now)? I did the same changes as in https://github.com/StanfordBDHG/.github/pull/47 (e.g., enabling in the action, minor fast lane changes). Seems like current PRs in the template app have a similar problem judging by their CI output (e.g., https://github.com/StanfordSpezi/SpeziTemplateApplication/pull/68)?

PSchmiedmayer commented 8 months ago

@Supereg Wanted to follow up on the password autofill issue; could we isolate this to a dedicated runner that causes this problem?

Supereg commented 8 months ago

Didn't have the time to further investigate this issue right now.

PSchmiedmayer commented 8 months ago

No worries; I will see what I can do this week 🚀

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 83.55556% with 222 lines in your changes are missing coverage. Please review.

Project coverage is 84.25%. Comparing base (c448c04) to head (2fe1b42).

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49/graphs/tree.svg?width=650&height=150&src=pr&token=19Q7N7RodK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG)](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG) ```diff @@ Coverage Diff @@ ## main #49 +/- ## ========================================== + Coverage 82.50% 84.25% +1.75% ========================================== Files 84 94 +10 Lines 3114 3301 +187 ========================================== + Hits 2569 2781 +212 + Misses 545 520 -25 ``` | [Files](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG) | Coverage Δ | | |---|---|---| | [NAMS/Account/AccountButton.swift](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG#diff-TkFNUy9BY2NvdW50L0FjY291bnRCdXR0b24uc3dpZnQ=) | `100.00% <ø> (ø)` | | | [NAMS/Account/AccountSetupHeader.swift](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG#diff-TkFNUy9BY2NvdW50L0FjY291bnRTZXR1cEhlYWRlci5zd2lmdA==) | `100.00% <ø> (ø)` | | | [NAMS/Account/AccountSheet.swift](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG#diff-TkFNUy9BY2NvdW50L0FjY291bnRTaGVldC5zd2lmdA==) | `95.00% <ø> (ø)` | | | [NAMS/Devices/BatteryIcon.swift](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG#diff-TkFNUy9EZXZpY2VzL0JhdHRlcnlJY29uLnN3aWZ0) | `86.67% <100.00%> (+7.36%)` | :arrow_up: | | [...s/Biopot/Characteristics/AccelerometerSample.swift](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG#diff-TkFNUy9EZXZpY2VzL0Jpb3BvdC9DaGFyYWN0ZXJpc3RpY3MvQWNjZWxlcm9tZXRlclNhbXBsZS5zd2lmdA==) | `85.72% <100.00%> (ø)` | | | [...ices/Biopot/Characteristics/ByteBuffer+Int24.swift](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG#diff-TkFNUy9EZXZpY2VzL0Jpb3BvdC9DaGFyYWN0ZXJpc3RpY3MvQnl0ZUJ1ZmZlcitJbnQyNC5zd2lmdA==) | `80.44% <ø> (ø)` | | | [...vices/Biopot/Characteristics/DataAcquisition.swift](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG#diff-TkFNUy9EZXZpY2VzL0Jpb3BvdC9DaGFyYWN0ZXJpc3RpY3MvRGF0YUFjcXVpc2l0aW9uLnN3aWZ0) | `87.81% <100.00%> (ø)` | | | [...S/Devices/Biopot/Recording/EEGChannel+Biopot.swift](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG#diff-TkFNUy9EZXZpY2VzL0Jpb3BvdC9SZWNvcmRpbmcvRUVHQ2hhbm5lbCtCaW9wb3Quc3dpZnQ=) | `95.46% <ø> (ø)` | | | [NAMS/Devices/Biopot/Views/BiopotDeviceRow.swift](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG#diff-TkFNUy9EZXZpY2VzL0Jpb3BvdC9WaWV3cy9CaW9wb3REZXZpY2VSb3cuc3dpZnQ=) | `100.00% <100.00%> (ø)` | | | [NAMS/Devices/Mock/MockMeasurementGenerator.swift](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG#diff-TkFNUy9EZXZpY2VzL01vY2svTW9ja01lYXN1cmVtZW50R2VuZXJhdG9yLnN3aWZ0) | `58.14% <ø> (ø)` | | | ... and [66 more](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG) | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG). Last update [c448c04...2fe1b42](https://app.codecov.io/gh/StanfordBDHG/NAMS/pull/49?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG).

Supereg commented 8 months ago

Okay, the run just went through 🙃

StanfordBDHG / NAMS