search

StanfordBDHG / NextJSTemplate

Biodesign Digital Health NextJS Template
https://stanfordbdhg.github.io/NextJSTemplate/
MIT License
1 stars 3 forks source link

Add .idea to Git ignore #17

Closed arkadiuszbachorski closed 5 months ago

arkadiuszbachorski commented 5 months ago

Add .idea to Git ignore

:recycle: Current situation & Problem

.idea is directory that stores per-project configuration of JetBrains IDEs. It shouldn't be versioned.

:gear: Release Notes

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

PSchmiedmayer commented 5 months ago

@arkadiuszbachorski I have fixed the eslint issues by updating our reusable GitHub Action to handle the state when we run the PRs from a fork, they all pass in the other PRs. Unfortunately re-running the GitHub Action here remembers the old version tag it used in the initial run (makes sense to make that reproducible) and therefore doesn't pick up the new change.

In addition @codecov seems to have run into an issue where they reached their GitHub rate limit: https://github.com/StanfordBDHG/NextJSTemplate/actions/runs/9289714498/job/25574778071?pr=17#step:6:34.

As we can't share a secret with a forked repo and they seem to struggle with that for a while I could see two options:

  1. Create the PRs (or merge them in one PR in this repo by creating a branch)
  2. I merge the PRs with my admin permissions.

I will go for (2) for now and will merge them in a sequential order.