StanfordBDHG / PediatricAppleWatchStudy

The Pediatric Apple Watch Study Application
MIT License
4 stars 0 forks source link

Supplemental Metrics for ECG Reading #46

Closed MatthewTurk247 closed 7 months ago

MatthewTurk247 commented 7 months ago

Supplemental Metrics for ECG Reading

:recycle: Current situation & Problem

Building on top of #40, this pull request seeks to package ECG readings with supplemental information like VO2 max and pulse rate in a way that is sensitive to the possible limitations of current recording capabilities.

:gear: Release Notes

:books: Documentation

In-line documentation will be written in relevant files in conformance to the Spezi Documentation Guide.

:white_check_mark: Testing

Tests may be added for ensuring that data is correctly serialized and properly handled.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (78f8287) 31.66% compared to head (37fb20e) 32.34%.

:exclamation: Current head 37fb20e differs from pull request most recent head 5fd48dd. Consider uploading reports for the commit 5fd48dd to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordBDHG/PediatricAppleWatchStudy/pull/46/graphs/tree.svg?width=650&height=150&src=pr&token=dxs74T2g0s&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG)](https://app.codecov.io/gh/StanfordBDHG/PediatricAppleWatchStudy/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG) ```diff @@ Coverage Diff @@ ## main #46 +/- ## ========================================== + Coverage 31.66% 32.34% +0.69% ========================================== Files 33 33 Lines 992 1002 +10 ========================================== + Hits 314 324 +10 Misses 678 678 ``` | [Files](https://app.codecov.io/gh/StanfordBDHG/PediatricAppleWatchStudy/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG) | Coverage Δ | | |---|---|---| | [PAWS/PAWSDelegate.swift](https://app.codecov.io/gh/StanfordBDHG/PediatricAppleWatchStudy/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG#diff-UEFXUy9QQVdTRGVsZWdhdGUuc3dpZnQ=) | `96.30% <100.00%> (+0.53%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordBDHG/PediatricAppleWatchStudy/pull/46?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordBDHG/PediatricAppleWatchStudy/pull/46?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG). Last update [78f8287...5fd48dd](https://app.codecov.io/gh/StanfordBDHG/PediatricAppleWatchStudy/pull/46?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordBDHG).
MatthewTurk247 commented 7 months ago

Moved to #47.