Closed MatthewTurk247 closed 7 months ago
Some questions for @PSchmiedmayer:
add
function in PAWSStandard
or modify the existing one that handles HKElectrocardiogram
?PAWS/ECGRecordings
?Attention: 101 lines
in your changes are missing coverage. Please review.
Comparison is base (
78f8287
) 31.66% compared to head (71e7d0e
) 30.33%.
@MatthewTurk247 Sorry for the late response!
While SpeziHealthKit is great to collect longitudinal data, I would suggest to use normal "custom" HealthKit queries for the 5 minute intervals around the measurements.
You can use the Spezi Delegate HealthKit configuration with a .manual()
delivery setting to make sure that permissions are granted during the onboarding but I would suggest that we develop a custom HealthKit query that gets triggered when a new ECG is recorded and received in the Standard that would then trigger the surrounding data collection.
I think it is fine to just store them in the database as they can be correlated with the ECG using the timestamps. In the long run we could work with FHIR references between the different documents but that might be too complicated for now. Just storing them as observations should be fine and should address our need.
We would also need some additional logic around the correlation of incoming symptoms and how to correlate this with the ECG types.
Let's use the meeting today to take a deep-dive into some of the implementation ideas and how we can address them as part of this and future PRs.
@MatthewTurk247 I would merge the PR if you agree that you don't want to make any additional changes? I can override the missing patch requirement. It will be nearly impossible to easily unit test them with the current testing capabilities that are available for HealthKit.
@MatthewTurk247 I would merge the PR if you agree that you don't want to make any additional changes? I can override the missing patch requirement. It will be nearly impossible to easily unit test them with the current testing capabilities that are available for HealthKit.
Yep, sounds good to me! I don't have any other changes in mind for this specific PR. So once that missing patch requirement is overridden and the PR is merged, I think it will make sense to open a new PR specifically for symptom tagging and linking to ECG recordings.
Sounds great; I have merged the PR 🎉
Thank you for all the work and research that went into the PR @MatthewTurk247 🚀
Supplemental Metrics for ECG Reading
:recycle: Current situation & Problem
Building on top of #40, this pull request seeks to package ECG readings with supplemental information like VO2 max and pulse rate in a way that is sensitive to the possible limitations of current recording capabilities.
:gear: Release Notes
:books: Documentation
In-line documentation will be written in relevant files in conformance to the Spezi Documentation Guide.
:white_check_mark: Testing
Tests may be added for ensuring that data is correctly serialized and properly handled.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: