StanfordBDHG / ResearchKit

ResearchKit with Swift Package Manager (SPM), SwiftUI, C++ Interoperability, and visionOS support

https://swiftpackageindex.com/StanfordBDHG/ResearchKit/documentation/researchkitswiftui

Other

7 stars 3 forks source link

Support Strict Concurrency #30

Closed Supereg closed 2 months ago

Supereg commented 2 months ago

Support Strict Concurrency

:recycle: Current situation & Problem

This PR enables strict concurrency for the ResearchKitSwiftUI targets. Swift 6 is now fully supported.

:gear: Release Notes

Compatibility with Swift 6

:books: Documentation

:white_check_mark: Testing

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

Supereg commented 2 months ago

Just saw that this PR isn't merged yet. Could you force merge this PR @PSchmiedmayer? I currently do not have the permission for that. Codecov sadly wasn't able to provide codecov results after two attempts.

Supereg commented 2 months ago

It seems like the main branch never collected any coverage reports? Also the last few PRs also didn't collect any coverage. Maybe it is a configuration issue?

Supereg commented 2 months ago

@PSchmiedmayer I updated the build_and_test action to also run on a push to main. This should ensure code coverage will work in the future.

PSchmiedmayer commented 2 months ago

Sure; thanks for the reminder! I just merged the PR 👍

Supereg commented 2 months ago

thank you 🚀