StanfordBDHG / ResearchKitOnFHIR

HL7 FHIR Structured Data Capture with ResearchKit on iOS
https://swiftpackageindex.com/StanfordBDHG/ResearchKitOnFHIR/documentation
MIT License
13 stars 2 forks source link

Fix for keyboard safe area covering input fields #55

Closed vishnuravi closed 1 year ago

vishnuravi commented 1 year ago

Fix for keyboard safe area covering input fields

:recycle: Current situation & Problem

The keyboard safe area sometimes covers the input field and leaves a large room between the keyboard and the control buttons (skip and next). Refer to this related issue.

:bulb: Proposed solution

Resolves this issue by adding .ignoresSafeArea(.keyboard, edges: .bottom) to the ORKOrderedTaskView which keeps the Next toolbar pinned to the bottom of the screen. Thank you @louie-apple for your help with this issue!

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 1 year ago

Codecov Report

Merging #55 (75d92e9) into main (50ccf6b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files           9        9           
  Lines         661      661           
=======================================
  Hits          585      585           
  Misses         76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50ccf6b...75d92e9. Read the comment docs.