StanfordHCI / bang

💥 Helping people meet for the first time, more than once 💥
MIT License
2 stars 1 forks source link

More control over duration of round #354

Closed madewithsmiles closed 5 years ago

madewithsmiles commented 5 years ago

We would like to have more control of the round duration. It looks like the rounds' duration are in a (fixed) time increment; I think the minimum is 10 mins. Since each round is composed of steps, we just want to have more control over the increment for a given step.

deliveryweb commented 5 years ago

Rule for round duration: if (values.roundMinutes < 1 || values.roundMinutes > 59) { errors.roundMinutes = 'invalid value' } Rules for step time: const time = parseFloat(step.time); if (time <= 0 || time >= 1) { errors.tasks[i].steps[j].time = 'invalid'; } else { if (j > 0 && parseFloat(task.steps[j - 1].time) > time ) { errors.tasks[i].steps[j].time = 'must be > previous step'; } }

So, I don't understand "It looks like the rounds' duration are in a (fixed) time increment"

madewithsmiles commented 5 years ago

Thanks! Let me see where I might have made the mistake then

markwhiting commented 5 years ago

Is this closed now?