search

StanfordHCI / bang

💥 Helping people meet for the first time, more than once 💥
MIT License
2 stars 1 forks source link

Chats for exprounds are not saving correctly. #415

Closed i-gao closed 5 years ago

i-gao commented 5 years ago

See this file, the json of 5d5db4f6df864404e27c2efb: batch (2).txt

The chats recorded for rounds 1 and 4 are exactly the same. For example, search this text: "Tea made from seaweed. Interesting."

It looks like the chats for the rounds with the same names save both rounds' data under their chat field.

For example, in batch 5d5db4f6df864404e27c2efb, expRounds = [1,4], and "chat" under rounds 1 and 4 both contain both round 1 and round 4's messages. (Helperbot's steps show up twice.) Rounds 2 and 3 look to be saving correctly.

Meanwhile, for batch 5d5c9acbdf864404e27bfa85, expRounds = [2,5], and "chat" under rounds 2 and 5 show both round 2 and round 5's messages.

As far as I can see from quickly checking on the UI, all batches after 5d5caf0edf864404e27c13e9 have this problem.

deliveryweb commented 5 years ago

They both are single team batches, right? I think something is wrong with new logic. Daniil will solve it.

i-gao commented 5 years ago

Yes. Awesome!

i-gao commented 5 years ago

hmm wait, not sure whether this is a fixed issue or not. prematurely closed, sorry!

deliveryweb commented 5 years ago

fixed, in prod