Closed phoebexy closed 4 years ago
Just wondering, why are there so many formatting changes? I assume everyone is using prettier with no private config file. Is it the case that someone has a different code formatter, or perhaps its not getting run every time, e.g., perhaps it was run this time but its not usually?
I think right now its not in the build path (its not called in the package.json scripts, just as a dependency):
"scripts": {
"start": "node built/server.js",
"test": "echo \"Error: no test specified\" && exit 1",
"start-front": "node front/scripts/start.js",
"build-front": "node front/scripts/build.js",
"test-front": "node front/scripts/test.js --env=jsdom"
}
@markwhiting I think this is my IDM autoformatter. But also I noticed general formatting issues with the javascript so I don't know if there was a consistent style we were following prior.
OK, perhaps run prettier on all the files that have changed and commit that here. (I'm not actually sure if prettier has been run every time people build though thats the intent) (more on that here → https://prettier.io), I'll add an issue about this so we can make sure that prettier is being used automatically.
@xehu thanks for the reminder! Forgot to change the "merge to" branch. This should be a bit more clear. It sounds like I will need to make some changes such that the repo work compatibly between our two experimental setups. Perhaps I could switch between our two logics depending on if: