StanfordHCI / bang

💥 Helping people meet for the first time, more than once 💥
MIT License
2 stars 1 forks source link

Fix bonus pricing and expectations #513

Closed markwhiting closed 4 years ago

markwhiting commented 4 years ago

Right now we have inconsistent bonuses and don't set expectations well, because we use different numbers in different places, and are not aligned with fair work's suggestion of $15/hour.

We should:

  1. Make sure the right bonuses are being calculated. Some related code: https://github.com/StanfordHCI/bang/blob/be112171d64ada4eac2432415dbb99fbe4562a28/server/controllers/batches.ts#L421 https://github.com/StanfordHCI/bang/blob/16f38b485de7db4791974284bccf014cbeb6192f/server/controllers/utils.ts#L654 https://github.com/StanfordHCI/bang/blob/2be5b412572d17b90d39541b7e1deb93c31cd100/server/controllers/admin.ts#L498

  2. Use a single variable in the code to set the rate everywhere, like this one: https://github.com/StanfordHCI/bang/blob/16f38b485de7db4791974284bccf014cbeb6192f/server/controllers/utils.ts#L95

  3. Set that variable to $15/hour

  4. Double check to make sure our messaging is correct and consistent https://github.com/StanfordHCI/bang/blob/be112171d64ada4eac2432415dbb99fbe4562a28/server/index.ts#L313 https://github.com/StanfordHCI/bang/blob/2be5b412572d17b90d39541b7e1deb93c31cd100/server/controllers/admin.ts#L684