search

StanfordHCI / flash-teams

2 stars 0 forks source link

Maggie confirm end team #219

Closed mgoulder closed 10 years ago

mgoulder commented 10 years ago

Created the confirmation alert for when the user clicks "end team". There are two versions of this alert-- one for when the team is ended once all events are complete and one for when the user tries to end the team early.

Right now it looks like the alerts are not updating the team name properly (the team name is New Flash Team for all of them- the default name) BUT the changes in my previous pull request fix this problem so it should work once they are merged =]

negarrahmati commented 10 years ago

@mgoulder I am not sure if announcing the percentage of remaining progress is appropriate since the progress status doesn't change when a task is delayed. Maybe we could just say that the team is still running?

Also, could you check if the team is still running based on live and remaining task arrays not based on curr_status_width? curr_status _width is updated based on the task arrays and I think this way it would be less error prone. This means that in order to realize whether or not the team is running you should:

  1. updateStatus()
  2. check if the length of arrays: live_tasks, remaining_tasks, and delayed_tasks are zero. If all these arrays are empty the team has finished.

Thanks! =]

mgoulder commented 10 years ago

@negarrahmati All done with the above changes:)