Closed ato1120 closed 10 years ago
dretelny
commented
10 years ago I am currently working on this!!! Did we decide to merge it for now? I guess I’ll just create another branch?
Daniela Retelny Stanford University Department of Management Science and Engineering (914) 450-2033 dretelny@stanford.edu www.danielaretelny.com
On Jul 11, 2014, at 1:30 PM, mgoulder notifications@github.com wrote:
Merged #238.
— Reply to this email directly or view it on GitHub.
ato1120
commented
10 years ago I think I had submitted the pull request for it as is a couple of days ago when we decided to file the fix as a separate bug and Maggie just had time to get to it, a new branch would be best, but I'm not sure what funny git things might have just happened if you were working on my branch.
On Fri, Jul 11, 2014 at 1:33 PM, dretelny notifications@github.com wrote:
I am currently working on this!!! Did we decide to merge it for now? I guess I’ll just create another branch?
Daniela Retelny Stanford University Department of Management Science and Engineering (914) 450-2033 dretelny@stanford.edu www.danielaretelny.com
On Jul 11, 2014, at 1:30 PM, mgoulder notifications@github.com wrote:
Merged #238.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub https://github.com/StanfordHCI/flash-startups/pull/238#issuecomment-48779681 .
dretelny
commented
10 years ago Sounds good!
Fortunately I didn’t make any changes to your branch since I have been reading through the code and playing with the IRB console to understand the structure of the JSONs/status. I’ll just create a new branch :) It will be nice to have the duplicate button on master anyways until we resolve this status issue!
Daniela Retelny Stanford University Department of Management Science and Engineering (914) 450-2033 dretelny@stanford.edu www.danielaretelny.com
On Jul 11, 2014, at 1:39 PM, A. To notifications@github.com wrote:
I think I had submitted the pull request for it as is a couple of days ago when we decided to file the fix as a separate bug and Maggie just had time to get to it, a new branch would be best, but I'm not sure what funny git things might have just happened if you were working on my branch.
On Fri, Jul 11, 2014 at 1:33 PM, dretelny notifications@github.com wrote:
I am currently working on this!!! Did we decide to merge it for now? I guess I’ll just create another branch?
Daniela Retelny Stanford University Department of Management Science and Engineering (914) 450-2033 dretelny@stanford.edu www.danielaretelny.com
On Jul 11, 2014, at 1:30 PM, mgoulder notifications@github.com wrote:
Merged #238.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub https://github.com/StanfordHCI/flash-startups/pull/238#issuecomment-48779681 .
— Reply to this email directly or view it on GitHub.
Duplicates the JSON and status of a team and into the team library. Although everything copies over well, eventually we want to change the line that says: copy.status = original.status in the controller and save a non-started status. This is not very simple, so we keep it as is for now.
Another solution is to default "copy" all teams before you press start - this requires more re-design, etc.
For the tester: check to make sure the team copies everything over (members, details for members, events, details for each event, and interactions). If you choose, you can try to run the duplicated team and then duplicate it and observe the 'copied status' issue. To be really robust, you can also check to make sure we did not corrupt the original team by duplicating it.