StanfordLegion / legion

The Legion Parallel Programming System
https://legion.stanford.edu
Apache License 2.0
685 stars 145 forks source link

Realm: GASNet wrapper reverted CMake build #1749

Closed elliottslaughter closed 2 months ago

elliottslaughter commented 2 months ago

I'm not quite sure what was intended, but this change totally broke our embedded GASNet build:

https://gitlab.com/StanfordLegion/legion/-/merge_requests/1427

The newly added cmake/FetchAndBuildGASNet.cmake apparently duplicates and does not respect the settings we have historically used for controlling GASNet:

https://github.com/StanfordLegion/legion/blob/bc02aaa0806336bb6ef9154dc18879e8e4d06acf/CMakeLists.txt#L386-L395

This means we ended up getting GASNet reverted to 2023.9.0. Also, the new build seems to have lost the functionality for building embedded GASNet with CUDA and HIP support.

This is definitely a blocker for our release because the embedded GASNet build is effectively completely broken now.

@eddy16112 @muraj

elliottslaughter commented 2 months ago

Fixed by: https://gitlab.com/StanfordLegion/legion/-/merge_requests/1445