StanfordLegion / legion

The Legion Parallel Programming System
https://legion.stanford.edu
Apache License 2.0
689 stars 144 forks source link

legion_prof_rs: assertion failed: creation_time < entry.time_range.stop.unwrap() #1773

Closed syamajala closed 1 month ago

syamajala commented 1 month ago

I updated to the lastest legion and I am seeing this when trying to generate archive profiles with legion_prof:

assertion failed: creation_time < entry.time_range.stop.unwrap() 

There are logs here: https://s3df.slac.stanford.edu/people/seshu/xpplx5720/prof_logs/

manopapad commented 1 month ago

@eddy16112 any idea what's happening here?

lightsighter commented 1 month ago

Which hash of Legion did you build with? Legate is pinned to an old version and probably doesn't have the update.

syamajala commented 1 month ago
commit b7af50505d35a0c5c271c8d96c398d7a9a6f0065 (HEAD -> master, origin/master, origin/HEAD)
Merge: 5e043d2b2 69be7d7c1
Author: Mike Bauer <michael.edward.bauer@gmail.com>
Date:   Thu Oct 10 05:25:55 2024 +0000

    Merge branch 'fixemptyregiondel' into 'master'

    Fix Empty Region Deletion

    See merge request StanfordLegion/legion!1492

I built legate from src and used --with-legion-src-dir and --with-clean

lightsighter commented 1 month ago

FWIW, with a profiler built from the latest Legion master these logs load for me and don't crash in the same way as before.

lightsighter commented 1 month ago

Ok, I guess you have to make archive profiles. I will look at what is going wrong tonight.

lightsighter commented 1 month ago

Another fix for implicit top-level task profiling. Will need to rebuild and rerun to capture new logs.

https://gitlab.com/StanfordLegion/legion/-/merge_requests/1495

syamajala commented 1 month ago

It seems to be working now: https://legion.stanford.edu/prof-viewer/?url=https://sapling2.stanford.edu/~seshu/xpplx5720/legion_prof/

Thanks!

lightsighter commented 1 month ago

Merged.