search

StanfordLegion / legion

The Legion Parallel Programming System
https://legion.stanford.edu
Apache License 2.0
687 stars 144 forks source link

hwloc-2.0 support #575

Open keszybz opened 5 years ago

keszybz commented 5 years ago

Hi, mpich 3.3 now requires hwloc>=2.0. It would be great if legion could be updated too. This was already signalled in #479 in February :(

streichler commented 5 years ago

Yes, this is somewhere on our task list. It's not super-high though, as you can almost certainly disable hwloc in the Legion/Realm build with no loss of functionality. (Or conversely, if you have a system that the linux-sysfs-based discovery code doesn't work as well as hwloc for, let me know and we'll consider bumping this up the priority list.)

keszybz commented 5 years ago

Thanks for the quick reply. I made a small patch to fix one of the two compilation issues. I also did the suggested thing and disabled the use of hwloc that does not compile...

Or conversely, if you have a system that the linux-sysfs-based discovery code doesn't work as well as hwloc for, let me know and we'll consider bumping this up the priority list.

I wish I knew ;) I'm just the packager here, and I'm only touching legion because I want to update mpich.

streichler commented 5 years ago

As mentioned in the pull request, I'd like this change to add hwloc-2.x support without losing hwloc-1.x support, so it'll all need to be ifdef-protected.

ghost commented 2 years ago

Still waiting for update to hwloc-2.6.0

ghost commented 2 years ago

If you have any patch please provide it as I could add it to gentoo ebuild

streichler commented 2 years ago

@scardracs As was suggested a while back, I think the simplest thing to do here is to remove the Legion package's dependence on hwloc entirely. We routinely build without hwloc in our development, so I'm not sure what the issue that @keszybz encountered before was. If you're not sure how to disable use of hwloc in Legion, please point me at your build script and I'll see if I can suggest something.

ghost commented 2 years ago

@scardracs As was suggested a while back, I think the simplest thing to do here is to remove the Legion package's dependence on hwloc entirely. We routinely build without hwloc in our development, so I'm not sure what the issue that @keszybz encountered before was. If you're not sure how to disable use of hwloc in Legion, please point me at your build script and I'll see if I can suggest something.

Yeah I know how to remove it, the only point is that Gentoo ebuild use +hwloc, which means is forced by default. If you prefer to remove it I can proceed on dropping it on Gentoo side (as I'm working on cleanup/maintain it)

streichler commented 2 years ago

I'm not that familiar with Gentoo's build system, but having Legion's use of hwloc be disabled by default sounds better to me.

ghost commented 2 years ago

I'm not that familiar with Gentoo's build system, but having Legion's use of hwloc be disabled by default sounds better to me.

Short answer:

Gentoo uses ebuilds, which use a list of flags (IUSE). On legion there is a IUSE="... +hwloc ..." and that means it is forced by default if not disabled system-wide. I'm gonna drop it this evening.