search

StanfordPL / x64asm

x86-64 assembler library
Apache License 2.0
470 stars 60 forks source link

speed/clean up existing regset iterators #154

Closed eschkufz closed 9 years ago

eschkufz commented 9 years ago

Low priority since these don't seem like they're on the critical path, but these could be smaller/faster.

eschkufz commented 9 years ago

There are some bugs in these that I just came across.

Bubbling this up to high priority since I need this for debugging.

eschkufz commented 9 years ago

I understand this now. It's another issue of static initialization order being undefined.

The problem is that the iterators reference the global sets which haven't necessarily been created yet.

I can get around this in stoke for now, so I'll downgrade this to low priority.

eschkufz commented 9 years ago

Can do now that the static initialization bugs are fixed.

eschkufz commented 9 years ago

I'm going to add a stylistic edit to this as well and change the interator classes to low_case as in

Type::const_iterator vs Type::ConstIterator