HLE/RTM instructions need to be marked as invalid

StanfordPL / x64asm

x86-64 assembler library

Apache License 2.0

465 stars 60 forks source link

HLE/RTM instructions need to be marked as invalid #229

Closed bchurchill closed 8 years ago

bchurchill commented 8 years ago

I'm pretty sure we can't handle any of these, so we should turn off x64asm support for these.

stefanheule commented 8 years ago

What exactly is "x64asm support"? Wouldn't we mark them as unsupported in the sandbox?

bchurchill commented 8 years ago

There's a column in the spreadsheet that basically means "actually, we should never assemble this".

bchurchill commented 8 years ago

That entry prevents the instruction from being compiled into x64asm at all.

stefanheule commented 8 years ago

Ah, ok. Either is fine with me.

bchurchill commented 8 years ago

I'm realizing that there's really no need to do this given the other fix to STOKE to use only whitelisted CpuFlags. I guess these instructions might be useful to someone, someday, so I'll leave them.