search

StanfordSNR / gg

The Stanford Builder
GNU General Public License v3.0
988 stars 71 forks source link

Fixes to use python3 instead of python2 #19

Closed ljenkins closed 5 years ago

ljenkins commented 5 years ago

The README says python3 is a requirement, yet these scripts use python2.

sadjad commented 5 years ago

Thank you, @ljenkins, for this fix! Merged.

ljenkins commented 5 years ago

Glad to have contributed.

BTW, I tried to get gg to build on arch linux and it failed, didn't have time this past weekend to look at why.

Have you tried building/running on arch linux?

Hopefully next weekend I will have time to look at the required changes.

Thanks

On 7/14/19 20:40, Sadjad Fouladi wrote:

Thank you, @ljenkinshttps://github.com/ljenkins, for this fix! Merged.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/StanfordSNR/gg/pull/19?email_source=notifications&email_token=AAECJRVFJZLDN5TFBW7XIFLP7PPR5A5CNFSM4IDSFEUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ4TJQI#issuecomment-511259841, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAECJRR3ILAQHPNEL2ZZ4BDP7PPR5ANCNFSM4IDSFEUA.

sadjad commented 5 years ago

I haven't tried it on Arch, but I just talked to a friend who tried it, and it seems that there's an issue with libcrypto++. I will take a look and try to fix it!

--Sadjad

ljenkins commented 5 years ago

I actually did some work on arch last weekend to try and get it working, but did not get it running in the time I had available.

As I recall, I did:

pacman -S hiredis

pacman -S crypto++

ln -s /usr/include/cryptopp /usr/include/crypto++ ### Name is different on arch

ln -s /usr/bin/gcc /usr/bin/gcc-7 #### I have gcc 9 installed

ld compained that it could not find -lcryptopp and -lprotobuf

Thanks

On 7/15/19 18:04, Sadjad Fouladi wrote:

I haven't tried it on Arch, but I just talked to a friend who tried it, and it seems that there's an issue with libcrypto++. I will take a look and try to fix it!

--Sadjad

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/StanfordSNR/gg/pull/19?email_source=notifications&email_token=AAECJRUSMYU4A755EVA2XBLP7UGBNA5CNFSM4IDSFEUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7JTRI#issuecomment-511613381, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAECJRTCJCNFYUXWKHEVR73P7UGBNANCNFSM4IDSFEUA.