search

StanfordSNR / puffer

Puffer is a free live TV streaming website and a research study at Stanford using machine learning to improve video streaming
https://puffer.stanford.edu
835 stars 131 forks source link

Pensieve branch #12

Closed francisyyan closed 5 years ago

francisyyan commented 5 years ago

For code review only

hudson-ayers commented 5 years ago

@francisyyan I think this PR is ready for another review, unless you want me to squash my commits and re-open

francisyyan commented 5 years ago

Done my review. Please free to leave "harsh" comments like removing extra new lines to me to resolve (even though they are not actually "harsh"; it's just because we are not using cpplint) :-)

hudson-ayers commented 5 years ago

Addressed all of your comments in my last commit (and fixed a small bug I found on my own). I also tested it with 7 simultaneous streams for 10 minutes, which worked fine. @francisyyan

francisyyan commented 5 years ago

Close this pull request as it was already merged. Thanks!