search

StanfordSpezi / Spezi

Open-source framework for rapid development of modern, interoperable digital health applications.
https://swiftpackageindex.com/StanfordSpezi/Spezi/documentation
MIT License
130 stars 10 forks source link

Migrate to @_spi instead of @testable #101

Closed Supereg closed 4 months ago

Supereg commented 4 months ago

Migrate to @_spi instead of @testable

:recycle: Current situation & Problem

Currently, we use @testable within XCTSpezi to access the internal interface of Spezi. This introduces complications for people using XCTSpezi. Using @_spi is also better as we have a reduced interface that we expose and even allow for others to leverage the same power when accessing the System Programming Interface.

:gear: Release Notes

:books: Documentation

--

:white_check_mark: Testing

--

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.97%. Comparing base (0ced3ef) to head (d698615).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/101/graphs/tree.svg?width=650&height=150&src=pr&token=KHU2K1HTAM&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #101 +/- ## ========================================== + Coverage 84.95% 84.97% +0.02% ========================================== Files 40 41 +1 Lines 950 951 +1 ========================================== + Hits 807 808 +1 Misses 143 143 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [Sources/Spezi/Module/ModuleCollection.swift](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aS9Nb2R1bGUvTW9kdWxlQ29sbGVjdGlvbi5zd2lmdA==) | `100.00% <ø> (ø)` | | | [...pezi/Spezi/KnowledgeSources/LaunchOptionsKey.swift](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aS9TcGV6aS9Lbm93bGVkZ2VTb3VyY2VzL0xhdW5jaE9wdGlvbnNLZXkuc3dpZnQ=) | `100.00% <ø> (ø)` | | | [Sources/Spezi/Spezi/Spezi.swift](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aS9TcGV6aS9TcGV6aS5zd2lmdA==) | `96.67% <100.00%> (ø)` | | | [Sources/Spezi/Standard/DefaultStandard.swift](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aS9TdGFuZGFyZC9EZWZhdWx0U3RhbmRhcmQuc3dpZnQ=) | `100.00% <100.00%> (ø)` | | | [Sources/XCTSpezi/DependencyResolution.swift](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9YQ1RTcGV6aS9EZXBlbmRlbmN5UmVzb2x1dGlvbi5zd2lmdA==) | `94.45% <ø> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/101?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/101?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [0ced3ef...d698615](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/101?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).