Closed Supereg closed 4 months ago
Attention: Patch coverage is 77.77778%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 84.97%. Comparing base (
ce8b29f
) to head (e32b690
).:exclamation: Current head e32b690 differs from pull request most recent head 06b5dc4. Consider uploading reports for the commit 06b5dc4 to get more accurate results
Fix visibility of NotificationHandler default implementations and make Delegate methods open
:recycle: Current situation & Problem
The
NotificationHandler
provides empty default implementations but their implementation are not marked public. Therefore, they have no effect. Secondly, someSpeziAppDelegate
methods are not declared as open. This reduces flexibility in certain cases where it might be helpful to inject custom logic or even just to debug some issues.:gear: Release Notes
SpeziAppDelegate
methods open.:books: Documentation
--
:white_check_mark: Testing
--
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: