StanfordSpezi / Spezi

Open-source framework for rapid development of modern, interoperable digital health applications.
https://swiftpackageindex.com/StanfordSpezi/Spezi/documentation
MIT License
145 stars 11 forks source link

Enable Strict Concurrency Checking #104

Closed pauljohanneskraft closed 2 months ago

pauljohanneskraft commented 5 months ago

Enable Strict Concurrency Checking

:recycle: Current situation & Problem

Fixes #103

:gear: Release Notes

:books: Documentation

No documentation changes needed, since strict concurrency checking does not emit any warnings and therefore does not require any changes to the actual implementation.

:white_check_mark: Testing

No additional tests needed, since the changes should only trigger more warnings by the compiler and otherwise not change anything.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

pauljohanneskraft commented 5 months ago

I opened this PR first to confirm that these are the intended changes or get feedback on whether you would like to have this set up a different way. If this is the intended way, I can then open PRs to all the other Spezi components.

pauljohanneskraft commented 5 months ago

I totally agree with 2, I set the SWIFT_STRICT_CONCURRENCY setting in UITests.xcodeproj to complete for all targets in this commit.

Regarding 1, I have added an input parameter to the workflow here.

PSchmiedmayer commented 2 months ago

Closed after we have updated the CI and setup in #108