StanfordSpezi / Spezi

Open-source framework for rapid development of modern, interoperable digital health applications.
https://swiftpackageindex.com/StanfordSpezi/Spezi/documentation
MIT License
130 stars 10 forks source link

Update LifecycleHandler to Use Scene Methods #67

Closed PSchmiedmayer closed 1 year ago

PSchmiedmayer commented 1 year ago

Update LifecycleHandler to Use Scene Methods

:recycle: Current situation & Problem

:bulb: Proposed solution

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 1 year ago

Codecov Report

Merging #67 (a81cb2c) into main (57ddc03) will increase coverage by 0.30%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/67/graphs/tree.svg?width=650&height=150&src=pr&token=KHU2K1HTAM&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #67 +/- ## ========================================== + Coverage 89.38% 89.68% +0.30% ========================================== Files 29 29 Lines 593 610 +17 ========================================== + Hits 530 547 +17 Misses 63 63 ``` | [Impacted Files](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...dule/Capabilities/Lifecycle/LifecycleHandler.swift](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aS9Nb2R1bGUvQ2FwYWJpbGl0aWVzL0xpZmVjeWNsZS9MaWZlY3ljbGVIYW5kbGVyLnN3aWZ0) | `100.00% <100.00%> (ø)` | | | [...pabilities/Lifecycle/Spezi+LifecycleHandlers.swift](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aS9Nb2R1bGUvQ2FwYWJpbGl0aWVzL0xpZmVjeWNsZS9TcGV6aStMaWZlY3ljbGVIYW5kbGVycy5zd2lmdA==) | `100.00% <100.00%> (ø)` | | | [Sources/Spezi/Spezi/SpeziAppDelegate.swift](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aS9TcGV6aS9TcGV6aUFwcERlbGVnYXRlLnN3aWZ0) | `96.56% <100.00%> (+0.72%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/67?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/67?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [57ddc03...a81cb2c](https://app.codecov.io/gh/StanfordSpezi/Spezi/pull/67?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).