search

StanfordSpezi / SpeziAccount

The Spezi Account module to enable login and signup functionality
https://swiftpackageindex.com/StanfordSpezi/SpeziAccount/documentation/
MIT License
5 stars 5 forks source link

Remove NavigationStacks from Setup and Overview and display SignupForm as a sheet #23

Closed Supereg closed 11 months ago

Supereg commented 11 months ago

Remove NavigationStacks from Setup and Overview and display SignupForm as a sheet

:recycle: Current situation & Problem

Currently, we automatically place a NavigationStack in the AccountSetup and AccountOverview views which causes due to nested NavigationStacks like in https://github.com/StanfordSpezi/SpeziOnboarding/issues/21.

This PR removes the NavigationStack dependence from the AccountSetup view by presenting the SignupForm as a sheet. Further, the AccountOverview now requires to be placed into a NavigationStack and doesn't automatically create one by itself.

:gear: Release Notes

:books: Documentation

Documentation was updated to reflect those new requirements.

:white_check_mark: Testing

Tests were updated and adjusted.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 11 months ago

Codecov Report

Merging #23 (3cd75b3) into main (040aec4) will decrease coverage by 0.27%. The diff coverage is 73.56%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23/graphs/tree.svg?width=650&height=150&src=pr&token=AudNwGU7tR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== - Coverage 76.22% 75.95% -0.27% ========================================== Files 112 112 Lines 3839 3916 +77 ========================================== + Hits 2926 2974 +48 - Misses 913 942 +29 ``` | [Files Changed](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...ount/Views/AccountOverview/AccountKeyEditRow.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvQWNjb3VudE92ZXJ2aWV3L0FjY291bnRLZXlFZGl0Um93LnN3aWZ0) | `88.34% <0.00%> (-11.66%)` | :arrow_down: | | [...ziAccount/Views/AccountOverview/NameOverview.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvQWNjb3VudE92ZXJ2aWV3L05hbWVPdmVydmlldy5zd2lmdA==) | `72.42% <0.00%> (ø)` | | | [Sources/SpeziAccount/AccountOverview.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudE92ZXJ2aWV3LnN3aWZ0) | `71.80% <14.29%> (-8.20%)` | :arrow_down: | | [...iews/AccountOverview/AccountOverviewSections.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvQWNjb3VudE92ZXJ2aWV3L0FjY291bnRPdmVydmlld1NlY3Rpb25zLnN3aWZ0) | `94.36% <66.67%> (ø)` | | | [Sources/SpeziAccount/Views/SignupForm.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvU2lnbnVwRm9ybS5zd2lmdA==) | `87.91% <77.78%> (-0.14%)` | :arrow_down: | | [Sources/SpeziAccount/AccountSetup.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNldHVwLnN3aWZ0) | `66.67% <83.68%> (+2.39%)` | :arrow_up: | | [...peziAccount/Views/UserIdPasswordEmbeddedView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvVXNlcklkUGFzc3dvcmRFbWJlZGRlZFZpZXcuc3dpZnQ=) | `86.73% <90.00%> (+0.75%)` | :arrow_up: | | [Sources/SpeziAccount/AccountConfiguration.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudENvbmZpZ3VyYXRpb24uc3dpZnQ=) | `65.00% <100.00%> (-0.68%)` | :arrow_down: | | [...SpeziAccount/AccountValue/Keys/PersonNameKey.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFZhbHVlL0tleXMvUGVyc29uTmFtZUtleS5zd2lmdA==) | `96.43% <100.00%> (-0.04%)` | :arrow_down: | | [...nt/Views/AccountOverview/PasswordChangeSheet.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvQWNjb3VudE92ZXJ2aWV3L1Bhc3N3b3JkQ2hhbmdlU2hlZXQuc3dpZnQ=) | `88.47% <100.00%> (ø)` | | | ... and [2 more](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [040aec4...3cd75b3](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/23?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).