search

StanfordSpezi / SpeziAccount

The Spezi Account module to enable login and signup functionality
https://swiftpackageindex.com/StanfordSpezi/SpeziAccount/documentation/
MIT License
5 stars 5 forks source link

Introduce the AccountNotifyStandard #24

Closed Supereg closed 1 year ago

Supereg commented 1 year ago

Introduce the AccountNotifyStandard

:recycle: Current situation & Problem

Currently, there is no way for an App to distinguish between Account logout and removal. This is especially important if the App associates other data (questionnaires, additional user information) with the user account that must be deleted as well.

This PR adds the AccountNotifyStandard constraint that allows to get notified about an account removal.

:gear: Release Notes

:books: Documentation

Documentation was added and updated.

:white_check_mark: Testing

Tests were added to verify functionality.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 1 year ago

Codecov Report

Merging #24 (050d79c) into main (1685d1c) will increase coverage by 0.09%. The diff coverage is 80.29%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/24/graphs/tree.svg?width=650&height=150&src=pr&token=AudNwGU7tR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #24 +/- ## ========================================== + Coverage 75.95% 76.03% +0.09% ========================================== Files 112 114 +2 Lines 3916 3959 +43 ========================================== + Hits 2974 3010 +36 - Misses 942 949 +7 ``` | [Files Changed](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [.../Wrapper/StorageStandardBackedAccountService.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvV3JhcHBlci9TdG9yYWdlU3RhbmRhcmRCYWNrZWRBY2NvdW50U2VydmljZS5zd2lmdA==) | `84.15% <ø> (ø)` | | | [Sources/SpeziAccount/AccountConfiguration.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudENvbmZpZ3VyYXRpb24uc3dpZnQ=) | `65.10% <71.43%> (+0.10%)` | :arrow_up: | | [...ccount/AccountService/Wrapper/StandardBacked.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvV3JhcHBlci9TdGFuZGFyZEJhY2tlZC5zd2lmdA==) | `72.10% <72.10%> (ø)` | | | [Sources/SpeziAccount/Account.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudC5zd2lmdA==) | `85.42% <100.00%> (+0.32%)` | :arrow_up: | | [...e/Wrapper/NotifyStandardBackedAccountService.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvV3JhcHBlci9Ob3RpZnlTdGFuZGFyZEJhY2tlZEFjY291bnRTZXJ2aWNlLnN3aWZ0) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/24?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/24?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [1685d1c...050d79c](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/24?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).