Closed NikolaiMadlener closed 11 months ago
Merging #26 (00a4972) into main (5937ed6) will increase coverage by
75.17%
. The diff coverage is42.70%
.:exclamation: Current head 00a4972 differs from pull request most recent head 0379c04. Consider uploading reports for the commit 0379c04 to get more accurate results
Again, thanks for your feedback @PSchmiedmayer! Will incorporate the suggestions as soon as possible :)
Sounds great, thank you @NikolaiMadlener 👍
@Supereg could you run the workflow for me ☺️🙏
The two tests seem to be failing due to some github runner issues, I suspect? Maybe you've had such a problem before and know a fix? @PSchmiedmayer @Supereg
Seems like I closed this PR by accident 🙈
In order to merge the PR, I tried to sign the commits retrospectively by rebasing.
Tried to use --committer-date-is-author-date
in the rebase but to my suprise the commit timestamps also got updated :/
Sorry for the circumstances @PSchmiedmayer, was the first time I tried signing a bunch of commits afterwards.
Thinking about how to resolve this now.
@NikolaiMadlener No worries. I think the best would be to delete the branch, recreate it from main, and then push your changes onto it and create a new PR.
I also gave you the permission to write to this repo so you can directly create it in this repo and we don't have to approve the CI runs 👍
Once you have the new PR in place I can approve it and we can merge it once all builds are passing. Thank you for the great contribution and free free to reach out about the next steps once we have the feature merged in the Template App 🚀
Add Customizable Area to AccountOverview
:recycle: Current situation & Problem
Like described in issue #25, some applications like the Spezi Template application could display some additional information such as licensing information or other settings at the bottom of the Account Overview. Furthermore, some developers might want to do it the other way around and link to account information within a settings page.
:bulb: Proposed Solution
Add footer components to AccountOverview, as suggested by @PSchmiedmayer Implement an additional "AccountHeader" that looks something like the one in the Apple Settings app, as suggested by @Supereg
:gear: Release Notes
This PR adds two major things.
A customizable content section ViewBuilder to the
AccountOverview
. Simply pass any view as a trailing closure of AccountOverview and it will be rendered as a Section right between the other AccountOverview information and the log out button. Here is an example:A
AccountHeader
, similar to the one of the iOS Settings App, that could be used as a button that brings a user to theAccountOverview
. Here is an example::books: Documentation
in progress
:white_check_mark: Testing
UI tests for the customizable content section have been written.
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: