StanfordSpezi / SpeziAccount

The Spezi Account module to enable login and signup functionality
https://swiftpackageindex.com/StanfordSpezi/SpeziAccount/documentation/
MIT License
6 stars 5 forks source link

Adding Spanish Localization #32

Closed stefanoleitner closed 1 year ago

stefanoleitner commented 1 year ago

Adding Spanish Localizable.strings

:gear: Release Notes

Direct Spanish Translation of Localizable.strings

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 1 year ago

Codecov Report

Merging #32 (21b5022) into main (81a2150) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/32/graphs/tree.svg?width=650&height=150&src=pr&token=AudNwGU7tR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/32?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #32 +/- ## ======================================= Coverage 76.01% 76.01% ======================================= Files 122 122 Lines 4417 4417 ======================================= Hits 3357 3357 Misses 1060 1060 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/32?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Ξ” = absolute (impact)`, `ΓΈ = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/32?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [81a2150...21b5022](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/32?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).
vishnuravi commented 1 year ago

Thank you @stefanogpt, this is really appreciated and will help Spezi apps reach an even broader population!

PSchmiedmayer commented 1 year ago

Thank you @stefanogpt for your first contribution, greatly appreciated!

Following up with some feedback in #33, it would be great if we can use the start of Spanish localization as a mechanism to improve our general localization setup taking a look at String Catalogues #22. That should make localizations in other languages simpler in the future and can more easily catch issues as shown in #33.

@vishnuravi also noted that you realized that there were some inconsistencies in the English translation, would be great to resolve this as well within the next release. It would be great if we can attach this to #33 πŸ‘

vishnuravi commented 1 year ago

Thank you @stefanogpt for your first contribution, greatly appreciated!

Following up with some feedback in #33, it would be great if we can use the start of Spanish localization as a mechanism to improve our general localization setup taking a look at String Catalogues #22. That should make localizations in other languages simpler in the future and can more easily catch issues as shown in #33.

@vishnuravi also noted that you realized that there were some inconsistencies in the English translation, would be great to resolve this as well within the next release. It would be great if we can attach this to #33 πŸ‘

Thanks @PSchmiedmayer. Since @stefanogpt is not yet familiar with iOS development, this was an easier method for him to be able to contribute his language expertise without needing to install Xcode. I will address #22 in the next PR #33.

PSchmiedmayer commented 1 year ago

Thank you @vishnuravi πŸš€