StanfordSpezi / SpeziAccount

The Spezi Account module to enable login and signup functionality
https://swiftpackageindex.com/StanfordSpezi/SpeziAccount/documentation/
MIT License
6 stars 5 forks source link

Upgrade to new Spezi and SpeziFoundation frameworks #36

Closed Supereg closed 1 year ago

Supereg commented 1 year ago

Upgrade to new Spezi and SpeziFoundation frameworks

:recycle: Current situation & Problem

This PR updates SpeziAccount to the latest changes of the Spezi and SpeziFoundation frameworks. Additionally, we migrate away from ObservableObject to the new Observable framework.

:gear: Release Notes

:books: Documentation

--

:white_check_mark: Testing

--

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 1 year ago

Codecov Report

Merging #36 (f9096ee) into main (80bd6be) will decrease coverage by 0.06%. The diff coverage is 50.80%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36/graphs/tree.svg?width=650&height=150&src=pr&token=AudNwGU7tR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #36 +/- ## ========================================== - Coverage 76.37% 76.30% -0.06% ========================================== Files 114 116 +2 Lines 3964 3962 -2 ========================================== - Hits 3027 3023 -4 - Misses 937 939 +2 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [Sources/SpeziAccount/Account.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudC5zd2lmdA==) | `83.34% <100.00%> (+0.30%)` | :arrow_up: | | [Sources/SpeziAccount/AccountConfiguration.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudENvbmZpZ3VyYXRpb24uc3dpZnQ=) | `63.86% <100.00%> (-1.70%)` | :arrow_down: | | [Sources/SpeziAccount/AccountHeader.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudEhlYWRlci5zd2lmdA==) | `0.00% <ø> (ø)` | | | [...s/SpeziAccount/AccountService/AccountService.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvQWNjb3VudFNlcnZpY2Uuc3dpZnQ=) | `80.00% <ø> (ø)` | | | [...ce/Configuration/AccountServiceConfiguration.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvQ29uZmlndXJhdGlvbi9BY2NvdW50U2VydmljZUNvbmZpZ3VyYXRpb24uc3dpZnQ=) | `100.00% <ø> (ø)` | | | [...Configuration/AccountServiceConfigurationKey.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvQ29uZmlndXJhdGlvbi9BY2NvdW50U2VydmljZUNvbmZpZ3VyYXRpb25LZXkuc3dpZnQ=) | `100.00% <ø> (ø)` | | | [...untService/Configuration/AccountServiceImage.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvQ29uZmlndXJhdGlvbi9BY2NvdW50U2VydmljZUltYWdlLnN3aWZ0) | `100.00% <ø> (ø)` | | | [...ountService/Configuration/AccountServiceName.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvQ29uZmlndXJhdGlvbi9BY2NvdW50U2VydmljZU5hbWUuc3dpZnQ=) | `66.67% <ø> (ø)` | | | [...ntService/Configuration/FieldValidationRules.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvQ29uZmlndXJhdGlvbi9GaWVsZFZhbGlkYXRpb25SdWxlcy5zd2lmdA==) | `81.09% <ø> (ø)` | | | [...untService/Configuration/RequiredAccountKeys.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvQ29uZmlndXJhdGlvbi9SZXF1aXJlZEFjY291bnRLZXlzLnN3aWZ0) | `75.00% <ø> (ø)` | | | ... and [45 more](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [80bd6be...f9096ee](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/36?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).
Supereg commented 1 year ago

@PSchmiedmayer once approved you may merge the PR. Diff is off due to changes in the Previews.