search

StanfordSpezi / SpeziAccount

The Spezi Account module to enable login and signup functionality
https://swiftpackageindex.com/StanfordSpezi/SpeziAccount/documentation/
MIT License
6 stars 5 forks source link

Restore functionality of the storage standard #40

Closed Supereg closed 1 year ago

Supereg commented 1 year ago

Restore functionality of the storage standard

:recycle: Current situation & Problem

This PR restores the functionality of the AccountStorageStandard. There was an issue with SpeziAccount where account creation wasn't correctly picked up by the configured storage standard. We had to reengineer some parts of the SpeziAccount infrastructure to ensure the Storage Standard is called at all times.

:gear: Release Notes

:books: Documentation

--

:white_check_mark: Testing

New tests cases were added to verify the functionality and protect us against regressions.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 1 year ago

Codecov Report

Merging #40 (fa06600) into main (d65ad46) will not change coverage. The diff coverage is 0.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40/graphs/tree.svg?width=650&height=150&src=pr&token=AudNwGU7tR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #40 +/- ## ===================================== Coverage 0.00% 0.00% ===================================== Files 116 116 Lines 3961 3971 +10 ===================================== - Misses 3961 3971 +10 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...nt/Views/AccountSetup/AccountServicesSection.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvQWNjb3VudFNldHVwL0FjY291bnRTZXJ2aWNlc1NlY3Rpb24uc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...SpeziAccount/Views/UserIdPasswordPrimaryView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvVXNlcklkUGFzc3dvcmRQcmltYXJ5Vmlldy5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [Sources/SpeziAccount/Account.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudC5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [.../AccountSetupViewStyle/AccountSetupViewStyle.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNldHVwVmlld1N0eWxlL0FjY291bnRTZXR1cFZpZXdTdHlsZS5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [...ountSetupViewStyle/IdentityProviderViewStyle.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNldHVwVmlld1N0eWxlL0lkZW50aXR5UHJvdmlkZXJWaWV3U3R5bGUuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...peziAccount/Mock/MockSignInWithAppleProvider.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvTW9jay9Nb2NrU2lnbkluV2l0aEFwcGxlUHJvdmlkZXIuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...s/SpeziAccount/Mock/MockSimpleAccountService.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvTW9jay9Nb2NrU2ltcGxlQWNjb3VudFNlcnZpY2Uuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [Sources/SpeziAccount/Views/SignupForm.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvU2lnbnVwRm9ybS5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [...s/SpeziAccount/Views/UserIdPasswordResetView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvVXNlcklkUGFzc3dvcmRSZXNldFZpZXcuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [Sources/SpeziAccount/AccountValue/AccountKey.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFZhbHVlL0FjY291bnRLZXkuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | ... and [6 more](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [d65ad46...fa06600](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/40?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).