search

StanfordSpezi / SpeziAccount

The Spezi Account module to enable login and signup functionality
https://swiftpackageindex.com/StanfordSpezi/SpeziAccount/documentation/
MIT License
6 stars 5 forks source link

Support dynamic type sizes and longer timeout for required account modifier #51

Closed Supereg closed 9 months ago

Supereg commented 9 months ago

Support dynamic type sizes and longer timeout for required account modifier

:recycle: Current situation & Problem

Currently, the accountRequired modifier provides 500ms for account details to be available, before it brings up the Account Sheet to enforce an account login. This time is to shorts and currently makes the Account Sheet pop up after fresh app starts for a few milliseconds. We increase the timeout to be more lenient.

Further, this PR addresses #50 by using the new ListRow and DynamicHStack views for all list row contents optimizing SpeziAccount for larger dynamic type sizes.

:gear: Release Notes

:books: Documentation

--

:white_check_mark: Testing

--

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 9 months ago

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (714f01a) 76.03% compared to head (fc196fa) 0.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51/graphs/tree.svg?width=650&height=150&src=pr&token=AudNwGU7tR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #51 +/- ## ========================================== - Coverage 76.03% 0.00% -76.02% ========================================== Files 117 116 -1 Lines 4016 4002 -14 ========================================== - Hits 3053 0 -3053 - Misses 963 4002 +3039 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...peziAccount/AccountValue/Keys/DateOfBirthKey.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFZhbHVlL0tleXMvRGF0ZU9mQmlydGhLZXkuc3dpZnQ=) | `0.00% <0.00%> (-87.50%)` | :arrow_down: | | [...SpeziAccount/AccountValue/Keys/PersonNameKey.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFZhbHVlL0tleXMvUGVyc29uTmFtZUtleS5zd2lmdA==) | `0.00% <0.00%> (-94.82%)` | :arrow_down: | | [...ces/SpeziAccount/AccountValue/Keys/UserIdKey.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFZhbHVlL0tleXMvVXNlcklkS2V5LnN3aWZ0) | `0.00% <0.00%> (-83.33%)` | :arrow_down: | | [...Account/ViewModifier/AccountRequiredModifier.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld01vZGlmaWVyL0FjY291bnRSZXF1aXJlZE1vZGlmaWVyLnN3aWZ0) | `0.00% <0.00%> (-96.66%)` | :arrow_down: | | [...ataDisplay/LocalizableStringBasedDisplayView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvRGF0YURpc3BsYXkvTG9jYWxpemFibGVTdHJpbmdCYXNlZERpc3BsYXlWaWV3LnN3aWZ0) | `0.00% <0.00%> (-57.14%)` | :arrow_down: | | [...unt/Views/DataDisplay/StringBasedDisplayView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvRGF0YURpc3BsYXkvU3RyaW5nQmFzZWREaXNwbGF5Vmlldy5zd2lmdA==) | `0.00% <0.00%> (-72.72%)` | :arrow_down: | | [Sources/SpeziAccount/Views/SignupForm.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvU2lnbnVwRm9ybS5zd2lmdA==) | `0.00% <0.00%> (-89.25%)` | :arrow_down: | | [...eziAccount/Views/Fields/GenderIdentityPicker.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvRmllbGRzL0dlbmRlcklkZW50aXR5UGlja2VyLnN3aWZ0) | `0.00% <0.00%> (-53.12%)` | :arrow_down: | | [.../SpeziAccount/Views/Fields/DateOfBirthPicker.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvRmllbGRzL0RhdGVPZkJpcnRoUGlja2VyLnN3aWZ0) | `0.00% <0.00%> (-70.10%)` | :arrow_down: | ... and [93 files with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [714f01a...fc196fa](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/51?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).