search

StanfordSpezi / SpeziAccount

The Spezi Account module to enable login and signup functionality
https://swiftpackageindex.com/StanfordSpezi/SpeziAccount/documentation/
MIT License
5 stars 5 forks source link

Inject security related modifier in single edit view #56

Closed Supereg closed 5 months ago

Supereg commented 5 months ago

Inject security related modifier in single edit view

:recycle: Current situation & Problem

This PR addresses an issue where the securityRelatedViewModifier of an account service was not injected into the single row edit view.

:gear: Release Notes

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 76.18%. Comparing base (76b69a9) to head (688e900).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/56/graphs/tree.svg?width=650&height=150&src=pr&token=AudNwGU7tR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #56 +/- ## ========================================== - Coverage 76.33% 76.18% -0.14% ========================================== Files 116 116 Lines 4012 4017 +5 ========================================== - Hits 3062 3060 -2 - Misses 950 957 +7 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/56?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...SpeziAccount/AccountValue/AccountKeyCategory.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/56?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccountValue%2FAccountKeyCategory.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFZhbHVlL0FjY291bnRLZXlDYXRlZ29yeS5zd2lmdA==) | `80.00% <ø> (ø)` | | | [...ziAccount/Views/AccountOverview/NameOverview.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/56?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FViews%2FAccountOverview%2FNameOverview.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvQWNjb3VudE92ZXJ2aWV3L05hbWVPdmVydmlldy5zd2lmdA==) | `69.85% <100.00%> (ø)` | | | [Sources/SpeziAccount/Account.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/56?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccount.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudC5zd2lmdA==) | `77.20% <25.00%> (-2.45%)` | :arrow_down: | | [...Views/AccountSetup/DefaultAccountSetupHeader.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/56?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FViews%2FAccountSetup%2FDefaultAccountSetupHeader.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld3MvQWNjb3VudFNldHVwL0RlZmF1bHRBY2NvdW50U2V0dXBIZWFkZXIuc3dpZnQ=) | `64.52% <0.00%> (-9.55%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/56?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/56?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [76b69a9...688e900](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/56?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).