search

StanfordSpezi / SpeziAccount

The Spezi Account module to enable login and signup functionality
https://swiftpackageindex.com/StanfordSpezi/SpeziAccount/documentation/
MIT License
5 stars 5 forks source link

Swift 6 compatibility #61

Closed Supereg closed 1 month ago

Supereg commented 1 month ago

Swift 6 compatibility

:recycle: Current situation & Problem

This PR enables strict concurrency checking for SpeziAccount and adds compatibility with Swift 6.

:gear: Release Notes

:books: Documentation

--

:white_check_mark: Testing

--

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.11%. Comparing base (2de0720) to head (fbe8012).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61/graphs/tree.svg?width=650&height=150&src=pr&token=AudNwGU7tR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #61 +/- ## ========================================== - Coverage 76.12% 76.11% -0.01% ========================================== Files 116 116 Lines 4020 4035 +15 ========================================== + Hits 3060 3071 +11 - Misses 960 964 +4 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [Sources/SpeziAccount/Account.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccount.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudC5zd2lmdA==) | `77.20% <ø> (ø)` | | | [...untService/Configuration/AccountServiceImage.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccountService%2FConfiguration%2FAccountServiceImage.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvQ29uZmlndXJhdGlvbi9BY2NvdW50U2VydmljZUltYWdlLnN3aWZ0) | `100.00% <ø> (ø)` | | | [...ount/AccountService/Configuration/UserIdType.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccountService%2FConfiguration%2FUserIdType.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvQ29uZmlndXJhdGlvbi9Vc2VySWRUeXBlLnN3aWZ0) | `90.00% <ø> (ø)` | | | [.../Wrapper/StorageStandardBackedAccountService.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccountService%2FWrapper%2FStorageStandardBackedAccountService.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNlcnZpY2UvV3JhcHBlci9TdG9yYWdlU3RhbmRhcmRCYWNrZWRBY2NvdW50U2VydmljZS5zd2lmdA==) | `96.30% <100.00%> (+0.05%)` | :arrow_up: | | [Sources/SpeziAccount/AccountSetup.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccountSetup.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNldHVwLnN3aWZ0) | `68.64% <ø> (ø)` | | | [.../AccountSetupViewStyle/AccountSetupViewStyle.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccountSetupViewStyle%2FAccountSetupViewStyle.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNldHVwVmlld1N0eWxlL0FjY291bnRTZXR1cFZpZXdTdHlsZS5zd2lmdA==) | `80.00% <ø> (ø)` | | | [...iewStyle/UserIdPasswordAccountSetupViewStyle.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccountSetupViewStyle%2FUserIdPasswordAccountSetupViewStyle.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFNldHVwVmlld1N0eWxlL1VzZXJJZFBhc3N3b3JkQWNjb3VudFNldHVwVmlld1N0eWxlLnN3aWZ0) | `90.00% <ø> (ø)` | | | [...ue/Configuration/AccountKeyConfigurationImpl.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccountValue%2FConfiguration%2FAccountKeyConfigurationImpl.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFZhbHVlL0NvbmZpZ3VyYXRpb24vQWNjb3VudEtleUNvbmZpZ3VyYXRpb25JbXBsLnN3aWZ0) | `29.63% <ø> (ø)` | | | [...alue/Configuration/AccountValueConfiguration.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccountValue%2FConfiguration%2FAccountValueConfiguration.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFZhbHVlL0NvbmZpZ3VyYXRpb24vQWNjb3VudFZhbHVlQ29uZmlndXJhdGlvbi5zd2lmdA==) | `87.15% <ø> (ø)` | | | [...ountValue/Configuration/ConfiguredAccountKey.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccountValue%2FConfiguration%2FConfiguredAccountKey.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFZhbHVlL0NvbmZpZ3VyYXRpb24vQ29uZmlndXJlZEFjY291bnRLZXkuc3dpZnQ=) | `63.16% <ø> (ø)` | | | ... and [12 more](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [2de0720...fbe8012](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/61?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).