Closed Supereg closed 2 months ago
Attention: Patch coverage is 95.45455%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 84.49%. Comparing base (
b9c1cb6
) to head (ef0f2c8
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...Account/ViewModifier/AccountRequiredModifier.swift | 95.24% | 1 Missing :warning: |
Thank you @Supereg!
accountRequired
modifier should not consider anonymous accounts by default.:recycle: Current situation & Problem
Currently, the
accountRequired(_:setupSheet:)
modifier considers any associated account details as a valid account and therefore dismisses the provided setup sheet. However, typically anonymous accounts are not considered full accounts and are only used to have a persistent account identifier. TheAccountSetup
sheet treats anonymous accounts similarly where it still shows all the signup options.This PR introduces a new flag passed to the
accountRequired(_:considerAnonymousAccounts:setupSheet:)
modifier to control the behavior of anonymous accounts. By default anonymous accounts are treated the same as if no account was present.:gear: Release Notes
accountRequired
modifier by default.:books: Documentation
Documentation was updated.
:white_check_mark: Testing
--
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: