search

StanfordSpezi / SpeziAccount

The Spezi Account module to enable login and signup functionality
https://swiftpackageindex.com/StanfordSpezi/SpeziAccount/documentation/
MIT License
6 stars 5 forks source link

Add `AccountKeyRequirement.manual` #75

Closed pauljohanneskraft closed 2 months ago

pauljohanneskraft commented 2 months ago

Add AccountKeyRequirement.manual

:recycle: Current situation & Problem

There is currently no way to add AccountKeys that shouldn't be shown to the user. Since this might still be reasonable though (e.g. to check a status of the user like enrollment in a study), we introduce AccountKeyRequirement.manual.

:gear: Release Notes

:books: Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide. You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

:white_check_mark: Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested. This section describes important information about the tests and why some elements might not be testable.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (7e78ee9) to head (c2d3c3d). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ountValue/Configuration/ConfiguredAccountKey.swift 66.67% 3 Missing :warning:
...ue/Configuration/AccountKeyConfigurationImpl.swift 50.00% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/75/graphs/tree.svg?width=650&height=150&src=pr&token=AudNwGU7tR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #75 +/- ## ========================================== - Coverage 84.49% 84.36% -0.12% ========================================== Files 120 120 Lines 5213 5221 +8 ========================================== Hits 4404 4404 - Misses 809 817 +8 ``` | [Files with missing lines](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/75?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...count/ViewModel/AccountOverviewFormViewModel.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/75?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FViewModel%2FAccountOverviewFormViewModel.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld01vZGVsL0FjY291bnRPdmVydmlld0Zvcm1WaWV3TW9kZWwuc3dpZnQ=) | `91.26% <100.00%> (ø)` | | | [...Account/ViewModifier/AccountRequiredModifier.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/75?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FViewModifier%2FAccountRequiredModifier.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld01vZGlmaWVyL0FjY291bnRSZXF1aXJlZE1vZGlmaWVyLnN3aWZ0) | `88.47% <ø> (-1.92%)` | :arrow_down: | | [.../ViewModifier/DisableFieldAssistantsModifier.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/75?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FViewModifier%2FDisableFieldAssistantsModifier.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvVmlld01vZGlmaWVyL0Rpc2FibGVGaWVsZEFzc2lzdGFudHNNb2RpZmllci5zd2lmdA==) | `100.00% <ø> (ø)` | | | [...ue/Configuration/AccountKeyConfigurationImpl.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/75?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccountValue%2FConfiguration%2FAccountKeyConfigurationImpl.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFZhbHVlL0NvbmZpZ3VyYXRpb24vQWNjb3VudEtleUNvbmZpZ3VyYXRpb25JbXBsLnN3aWZ0) | `34.38% <50.00%> (-2.29%)` | :arrow_down: | | [...ountValue/Configuration/ConfiguredAccountKey.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/75?src=pr&el=tree&filepath=Sources%2FSpeziAccount%2FAccountValue%2FConfiguration%2FConfiguredAccountKey.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUFjY291bnQvQWNjb3VudFZhbHVlL0NvbmZpZ3VyYXRpb24vQ29uZmlndXJlZEFjY291bnRLZXkuc3dpZnQ=) | `60.00% <66.67%> (-3.15%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/75/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/75?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/75?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [7e78ee9...c2d3c3d](https://app.codecov.io/gh/StanfordSpezi/SpeziAccount/pull/75?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).