StanfordSpezi / SpeziBluetooth

Connect and communicate with Bluetooth devices.
https://swiftpackageindex.com/StanfordSpezi/SpeziBluetooth/documentation/spezibluetooth
MIT License
11 stars 2 forks source link

Move ByteCodable to SpeziFileFormats package #19

Closed Supereg closed 6 months ago

Supereg commented 6 months ago

Move ByteCodable to SpeziFileFormats package

:recycle: Current situation & Problem

The set ByteCodable protocols were recently moved to the SpeziFileFormats package. This PR removes these protocols and migrates to the new library.

:gear: Release Notes

:books: Documentation

Documentation and links were updated.

:white_check_mark: Testing

--

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 98.38710% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.90%. Comparing base (b8e0a7f) to head (91644f0). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19/graphs/tree.svg?width=650&height=150&src=pr&token=mgZAjyPJH4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #19 +/- ## ========================================== + Coverage 73.41% 73.90% +0.50% ========================================== Files 78 70 -8 Lines 3523 3318 -205 ========================================== - Hits 2586 2452 -134 + Misses 937 866 -71 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...s/BluetoothServices/Characteristics/DateTime.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9CbHVldG9vdGhTZXJ2aWNlcy9DaGFyYWN0ZXJpc3RpY3MvRGF0ZVRpbWUuc3dpZnQ=) | `94.88% <100.00%> (ø)` | | | [...Services/Characteristics/MeasurementInterval.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9CbHVldG9vdGhTZXJ2aWNlcy9DaGFyYWN0ZXJpc3RpY3MvTWVhc3VyZW1lbnRJbnRlcnZhbC5zd2lmdA==) | `96.16% <100.00%> (ø)` | | | [...rces/BluetoothServices/Characteristics/PnPID.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9CbHVldG9vdGhTZXJ2aWNlcy9DaGFyYWN0ZXJpc3RpY3MvUG5QSUQuc3dpZnQ=) | `80.65% <100.00%> (ø)` | | | [...vices/Characteristics/TemperatureMeasurement.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9CbHVldG9vdGhTZXJ2aWNlcy9DaGFyYWN0ZXJpc3RpY3MvVGVtcGVyYXR1cmVNZWFzdXJlbWVudC5zd2lmdA==) | `95.84% <100.00%> (ø)` | | | [...oothServices/Characteristics/TemperatureType.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9CbHVldG9vdGhTZXJ2aWNlcy9DaGFyYWN0ZXJpc3RpY3MvVGVtcGVyYXR1cmVUeXBlLnN3aWZ0) | `90.00% <100.00%> (ø)` | | | [...es/BluetoothServices/TestingSupport/EventLog.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9CbHVldG9vdGhTZXJ2aWNlcy9UZXN0aW5nU3VwcG9ydC9FdmVudExvZy5zd2lmdA==) | `77.22% <100.00%> (ø)` | | | [Sources/SpeziBluetooth/Bluetooth.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUJsdWV0b290aC9CbHVldG9vdGguc3dpZnQ=) | `89.81% <ø> (ø)` | | | [...eziBluetooth/Model/Properties/Characteristic.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUJsdWV0b290aC9Nb2RlbC9Qcm9wZXJ0aWVzL0NoYXJhY3RlcmlzdGljLnN3aWZ0) | `88.58% <ø> (ø)` | | | [...Model/PropertySupport/CharacteristicAccessor.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUJsdWV0b290aC9Nb2RlbC9Qcm9wZXJ0eVN1cHBvcnQvQ2hhcmFjdGVyaXN0aWNBY2Nlc3Nvci5zd2lmdA==) | `35.30% <ø> (ø)` | | | [...rtySupport/CharacteristicPeripheralInjection.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUJsdWV0b290aC9Nb2RlbC9Qcm9wZXJ0eVN1cHBvcnQvQ2hhcmFjdGVyaXN0aWNQZXJpcGhlcmFsSW5qZWN0aW9uLnN3aWZ0) | `77.35% <75.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [e9cbb29...91644f0](https://app.codecov.io/gh/StanfordSpezi/SpeziBluetooth/pull/19?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).