search

StanfordSpezi / SpeziFirebase

Google Firebase Spezi Modules
https://swiftpackageindex.com/StanfordSpezi/SpeziFirebase/documentation/
MIT License
3 stars 2 forks source link

Upgrade Spezi and SpeziAccount #23

Closed Supereg closed 10 months ago

Supereg commented 10 months ago

Upgrade Spezi and SpeziAccount

:recycle: Current situation & Problem

This PR updates to the latest releases of Spezi and SpeziAccount. By employing the newly release framework features we are resolving #14, #15 and removing the modifier workaround to retrieve the authorization controller again.

For more information see https://github.com/StanfordSpezi/SpeziAccount/pull/36.

:gear: Release Notes

:books: Documentation

--

:white_check_mark: Testing

--

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 10 months ago

Codecov Report

Merging #23 (ec99f6f) into main (187d1ed) will increase coverage by 1.50%. The diff coverage is 84.90%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23/graphs/tree.svg?width=650&height=150&src=pr&token=Z84BufPFgU&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== + Coverage 58.60% 60.10% +1.50% ========================================== Files 17 19 +2 Lines 1053 1070 +17 ========================================== + Hits 617 643 +26 + Misses 436 427 -9 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...iFirebaseAccount/Models/FirebaseAccountModel.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUZpcmViYXNlQWNjb3VudC9Nb2RlbHMvRmlyZWJhc2VBY2NvdW50TW9kZWwuc3dpZnQ=) | `100.00% <100.00%> (ø)` | | | [.../SpeziFirebaseAccount/Models/FirebaseContext.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUZpcmViYXNlQWNjb3VudC9Nb2RlbHMvRmlyZWJhc2VDb250ZXh0LnN3aWZ0) | `92.04% <100.00%> (ø)` | | | [...irebaseAccount/Views/FirebaseAccountModifier.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUZpcmViYXNlQWNjb3VudC9WaWV3cy9GaXJlYmFzZUFjY291bnRNb2RpZmllci5zd2lmdA==) | `100.00% <100.00%> (+23.53%)` | :arrow_up: | | [...ziFirebaseConfiguration/ConfigureFirebaseApp.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUZpcmViYXNlQ29uZmlndXJhdGlvbi9Db25maWd1cmVGaXJlYmFzZUFwcC5zd2lmdA==) | `100.00% <ø> (ø)` | | | [...count/AccountValues/FirebaseEmailVerifiedKey.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUZpcmViYXNlQWNjb3VudC9BY2NvdW50VmFsdWVzL0ZpcmViYXNlRW1haWxWZXJpZmllZEtleS5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [...Services/FirebaseEmailPasswordAccountService.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUZpcmViYXNlQWNjb3VudC9BY2NvdW50IFNlcnZpY2VzL0ZpcmViYXNlRW1haWxQYXNzd29yZEFjY291bnRTZXJ2aWNlLnN3aWZ0) | `91.51% <93.11%> (+1.61%)` | :arrow_up: | | [...ccount/AccountValues/FirebaseOAuthCredential.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUZpcmViYXNlQWNjb3VudC9BY2NvdW50VmFsdWVzL0ZpcmViYXNlT0F1dGhDcmVkZW50aWFsLnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [...eAccount/Views/ReauthenticationAlertModifier.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUZpcmViYXNlQWNjb3VudC9WaWV3cy9SZWF1dGhlbnRpY2F0aW9uQWxlcnRNb2RpZmllci5zd2lmdA==) | `95.24% <95.24%> (ø)` | | | [...ount/Account Services/FirebaseAccountService.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUZpcmViYXNlQWNjb3VudC9BY2NvdW50IFNlcnZpY2VzL0ZpcmViYXNlQWNjb3VudFNlcnZpY2Uuc3dpZnQ=) | `78.41% <82.36%> (-0.60%)` | :arrow_down: | | [...FirebaseAccount/FirebaseAccountConfiguration.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUZpcmViYXNlQWNjb3VudC9GaXJlYmFzZUFjY291bnRDb25maWd1cmF0aW9uLnN3aWZ0) | `88.10% <64.29%> (-11.90%)` | :arrow_down: | | ... and [1 more](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [187d1ed...ec99f6f](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/23?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).